Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[venus-messager] vsm发过来的GasFeeCap被venus-messager重新预估 #5546

Closed
1 of 11 tasks
Tracked by #5580 ...
cloudxin opened this issue Dec 8, 2022 · 7 comments
Closed
1 of 11 tasks
Tracked by #5580 ...
Assignees
Labels
C-bug Category: This is a bug C-duplicate Category: duplicate issue CU-force-community Category: from force community

Comments

@cloudxin
Copy link

cloudxin commented Dec 8, 2022

链服务模块 / Chain Service Components

  • venus
  • venus-auth
  • venus-gateway
  • venus-messager
  • venus-miner
  • 文档 / docs

订单服务模块 / Deal Service Components

  • venus-market
  • 文档 / docs

算力服务模块 / Storage Power Service Components

  • venus-sector-manager
  • venus-worker
  • 文档 / docs

版本 / Version

venus-messager -v
venus message version 1.8.0+git.a1b2601

描述 / Describe the Bug

默认的maxFee为7000000000000000,会导致vsm过来的消息GasFeeCap不生效
venus-messager share-params get
{
"id": 1,
"gasOverEstimation": 1.25,
"maxFee": "7000000000000000",
"gasFeeCap": "0",
"gasOverPremium": 0,
"baseFee": "0",
"selMsgNum": 20
}

当把maxFee调整到100000000000000000000000,传到venus-messager的GasFeeCap就生效
venus-messager share-params set --max-fee 100000000000000000000000

日志 / Logging Information

"Nonce": 348,
"Value": "0",
"GasLimit": 57597580,
"GasFeeCap": "1215328838",
"GasPremium": "99995",
"Method": 7,
修改配置之前的GasFeeCap为1215328838;


"Nonce": 349,
"Value": "0",
"GasLimit": 57603820,
"GasFeeCap": "5000000000",
"GasPremium": "100055",
"Method": 7,
修改配置之后过来的消息GasFeeCap为5nano,符合预期目标

重现步骤 / Repo Steps

No response

@cloudxin cloudxin added the C-bug Category: This is a bug label Dec 8, 2022
@Fatman13 Fatman13 added the CU-force-community Category: from force community label Dec 9, 2022
@simlecode simlecode mentioned this issue Dec 19, 2022
36 tasks
@diwufeiwen diwufeiwen self-assigned this Dec 21, 2022
@diwufeiwen
Copy link
Contributor

我的理解是这种情况只出现在ReplaceMessage的情况,并且maxFee调整到100000000000000000000000也没有按vsm传过来的计算,是按100000000000000000000000计算的,只是结果跟正常情况下的计算的结果差不多而已

@hunjixin
Copy link
Contributor

费用上限太低,会自动减少feecap,

@diwufeiwen
Copy link
Contributor

diwufeiwen commented Dec 22, 2022

用vsm传过来的值判断要替换的MaxFee是否合理,目前逻辑是有问题的

@diwufeiwen diwufeiwen assigned hunjixin and unassigned diwufeiwen Dec 22, 2022
@hunjixin
Copy link
Contributor

默认使用global最大费用我觉得没问题。 这种情况

  1. 默认值不满足需求,修改默认值, 像 @cloudxin 做的
  2. 如果是真的需要临时提升maxfee上线,replace命令有maxfee参数可以指定

@hunjixin
Copy link
Contributor

如果仅考虑cluster应用场景, 是应当把maxfee提升到一个比较大的值。

@hunjixin
Copy link
Contributor

hunjixin commented Dec 22, 2022

feecap/maxfee 设置是一个单价和总价的关系。
那么一个想法是:是否可以改成这样子

  1. 用户仅设置了feecap, 则采用一个大的值(比如100fil),用以绕过节点上的最小费用设置。
  2. 用户仅设置了maxfee,按目前的逻辑。
  3. 用户即设置了feecap又设置了maxfee, 不做处理 (后两种情况相同)

@diwufeiwen
Copy link
Contributor

这个issue的结论:设计如此,优化新开issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug C-duplicate Category: duplicate issue CU-force-community Category: from force community
Projects
Archived in project
Development

No branches or pull requests

4 participants