Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[venus-messager] gas valuation optimization of msg / 消息gas估值优化 #5618

Open
1 of 11 tasks
Tracked by #5626
, #5979
...
diwufeiwen opened this issue Dec 29, 2022 · 3 comments
Open
1 of 11 tasks
Tracked by #5626
, #5979
...

[venus-messager] gas valuation optimization of msg / 消息gas估值优化 #5618

diwufeiwen opened this issue Dec 29, 2022 · 3 comments
Assignees
@simlecode
Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon
Milestone
Sophon v1.12.0 / ...

Comments

@diwufeiwen
Copy link
Contributor

链服务模块 / Chain Service Components

  • venus
  • venus-auth
  • venus-gateway
  • venus-messager
  • venus-miner
  • 文档 / docs

订单服务模块 / Deal Service Components

  • venus-market
  • 文档 / docs

算力服务模块 / Storage Power Service Components

  • venus-sector-manager
  • venus-worker
  • 文档 / docs

描述 / Description

feecap/maxfee 设置是一个单价和总价的关系。
那么一个想法是：是否可以改成这样子

用户仅设置了feecap， 则采用一个大的值（比如100fil），用以绕过节点上的最小费用设置。
用户仅设置了maxfee，按目前的逻辑。
用户即设置了feecap又设置了maxfee， 不做处理 （后两种情况相同）
@diwufeiwen diwufeiwen added the C-enhancement Category: feature enhancement label Dec 29, 2022
@diwufeiwen diwufeiwen changed the title [venus-messager] 消息feecap/maxfee估值优化 [venus-messager] gas valuation optimization of msg / 消息gas估值优化 Dec 29, 2022
@diwufeiwen diwufeiwen added the P2 Medium - we should get to this soon label Dec 29, 2022
@Fatman13
Copy link
Contributor

gas得谨慎。逻辑尽量保持和lotus同步？默认值上，稍微对新人友好一些？

@Fatman13
Copy link
Contributor

关联讨论：

@Fatman13 Fatman13 mentioned this issue Dec 30, 2022
Closed
6 tasks
@Fatman13 Fatman13 mentioned this issue May 22, 2023
Closed
26 tasks
@elvin-du
Copy link
Collaborator

elvin-du commented Aug 1, 2023

把maxfee改成1Fil

@elvin-du elvin-du assigned elvin-du and simlecode and unassigned elvin-du Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simlecode simlecode

Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon
Projects
Venus Project
Status: No status
Milestone
Sophon v1.12.0 / 智子 v1.12.0
Development

No branches or pull requests
4 participants
@Fatman13 @elvin-du @diwufeiwen @simlecode