Replace hardcoded test timeout and parallelism flags with defaults. #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specified parallism of 8 was counter-productive on machines with fewer cores, and the hardcoded flag was impossible to override from the outside. This now uses the Go default of GOMAXPROCS (which is #cores). The CI config sets parallelism explicitly to suit container size. The specified timeout was also impossible to override when a shorter value was wanted for development. The CI config now sets the 30m value, but this is way more than we need.
travisperson
approved these changes
May 14, 2019
acruikshank
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specified parallelism of 8 was counter-productive on machines with fewer cores, and the
hardcoded flag was impossible to override from the outside. This now uses the Go default
of GOMAXPROCS (which is #cores). The CI config sets parallelism explicitly to suit container
size.
The specified timeout was also impossible to override when a shorter value was wanted for development. The CI config now sets the 30m value, but this is much more than we currently need.
I think these issues contributed to #2711.