Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4910 venus : add market api #4965

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

LinZexiao
Copy link
Collaborator

Related Issues

Proposed Changes

add market share api:
AddFsPieceStorage
ListPieceStorage
RemovePieceStorage

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@LinZexiao LinZexiao requested a review from simlecode June 23, 2022 05:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #4965 (0f80d85) into master (b10a936) will decrease coverage by 0%.
The diff coverage is 0%.

❗ Current head 0f80d85 differs from pull request most recent head dfd3210. Consider uploading reports for the commit dfd3210 to get more accurate results

@@          Coverage Diff           @@
##           master   #4965   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         597     597           
  Lines       64991   65031   +40     
======================================
- Hits        16575   16563   -12     
- Misses      46254   46303   +49     
- Partials     2162    2165    +3     

@LinZexiao LinZexiao force-pushed the feat/tanlang/market_addPieceStorage branch 2 times, most recently from 30d388f to 95aa71f Compare June 30, 2022 10:08
@LinZexiao LinZexiao requested a review from diwufeiwen July 1, 2022 08:48
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

第一个commit messager格式不太符合规范要求,其他挺好

venus-shared/api/market/api.go Outdated Show resolved Hide resolved
venus-shared/api/market/api.go Show resolved Hide resolved
aim to list piece storage
AddFsPieceStorage
RemovePieceStorage
GetPieceStorages
@LinZexiao LinZexiao force-pushed the feat/tanlang/market_addPieceStorage branch from 95aa71f to 0f80d85 Compare July 4, 2022 02:13
@LinZexiao LinZexiao requested a review from diwufeiwen July 4, 2022 02:29
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit ca52e7c into master Jul 4, 2022
@diwufeiwen diwufeiwen deleted the feat/tanlang/market_addPieceStorage branch July 4, 2022 07:23
@LinZexiao LinZexiao restored the feat/tanlang/market_addPieceStorage branch July 4, 2022 09:35
simlecode pushed a commit that referenced this pull request Jul 20, 2022
* feat: add share market piecestorage type
* feat: add market api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants