Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unit tests and STM annotations for chain module. #5434

Merged
merged 13 commits into from
Nov 11, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Nov 1, 2022

关联的Issues (Related Issues)

closes #5421

改动 (Proposed Changes)

feat: unit tests and STM annotations for chain module.

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@zl03jsj zl03jsj marked this pull request as draft November 1, 2022 07:57
@zl03jsj zl03jsj self-assigned this Nov 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #5434 (5957f73) into master (d2d388e) will increase coverage by 1%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #5434    +/-   ##
=======================================
+ Coverage      24%     26%    +1%     
=======================================
  Files         605     605            
  Lines       67861   67864     +3     
=======================================
+ Hits        16924   17693   +769     
+ Misses      48750   47913   -837     
- Partials     2187    2258    +71     

@zl03jsj zl03jsj force-pushed the feat/adding-stm-anotations branch 2 times, most recently from 44609c2 to a6e70b3 Compare November 9, 2022 05:52
@zl03jsj zl03jsj marked this pull request as ready for review November 11, 2022 03:36
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 62ce187 into master Nov 11, 2022
@simlecode simlecode deleted the feat/adding-stm-anotations branch November 11, 2022 06:44
@zl03jsj zl03jsj mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

venus 完善必要的测试用例, 添加STM注解
4 participants