Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: evm: align events implementation with FIP-0049 and FIP-0054 #5695

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

#5550
lotus pr: filecoin-project/lotus#10152

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Feb 7, 2023
@simlecode simlecode added the nv18 nv18-fevm label Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5695 (10eac96) into feat/nv18-fevm (7b84fce) will decrease coverage by 1%.
The diff coverage is 19%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/nv18-fevm   #5695     +/-   ##
================================================
- Coverage              25%     24%     -1%     
================================================
  Files                 636     647     +11     
  Lines               74366   77851   +3485     
================================================
+ Hits                18647   19247    +600     
- Misses              53225   56020   +2795     
- Partials             2494    2584     +90     

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 554a814 into feat/nv18-fevm Feb 7, 2023
@diwufeiwen diwufeiwen deleted the feat/events-alignment branch February 7, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nv18 nv18-fevm
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants