Update ttfb recording to only happen on success #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanzo
approved these changes
Oct 23, 2023
|
Can you fix conflicts |
|
@hannahhoward since this is basically a one line change, I added this change to another PR here: #25. cc @guanzo as a side note, @hannahhoward you seem to have a js formatter that is different from the default one Eric and I use on this repo. I think we should agree on some prettier / eslint setup for all our our JS repos. The formatters changing the code makes it inconsistent and also makes PRs hard to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Since we're trying to seperate our time to first successful byte from time to response in our metrics, we should only record TTFB when the response is a success
Implementation
Move TTFB recording to after the check for a failure