Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade Dockerfile to Node.js 20 LTS #289

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Dec 5, 2023

Interestingly enough, this seems to fix the network errors we observed before 🤷🏻‍♂️

Example of such errors:

npm ERR! code ECONNRESET
npm ERR! errno ECONNRESET
npm ERR! network request to https://registry.npmjs.org/is-network-error/-/is-network-error-1.0.0.tgz failed, reason: socket hang up
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos marked this pull request as draft December 5, 2023 15:31
@bajtos bajtos changed the title fix docker build feat: upgrade Dockerfile to Node.js 20 LTS Dec 5, 2023
@bajtos bajtos marked this pull request as ready for review December 5, 2023 15:34
@bajtos
Copy link
Member Author

bajtos commented Dec 5, 2023

If we encounter this problem in the future, another possible fix is to upgrade npm to the latest version as part of our Dockerfile script. Quoting from nodejs/docker-node#1668 (comment):

RUN npm cache clean --force && \
    npm install -g npm@latest && \
    npm install

@bajtos bajtos enabled auto-merge (squash) December 5, 2023 15:35
@bajtos bajtos merged commit 320cd0a into main Dec 5, 2023
18 checks passed
@bajtos bajtos deleted the fix-docker-build branch December 5, 2023 19:14
@bajtos
Copy link
Member Author

bajtos commented Dec 6, 2023

@bajtos bajtos changed the title feat: upgrade Dockerfile to Node.js 20 LTS dips: upgrade Dockerfile to Node.js 20 LTS Dec 6, 2023
@bajtos bajtos changed the title dips: upgrade Dockerfile to Node.js 20 LTS deps: upgrade Dockerfile to Node.js 20 LTS Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants