Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose additional Lassie configuration options #30

Merged
merged 4 commits into from
Jun 26, 2023
Merged

feat: expose additional Lassie configuration options #30

merged 4 commits into from
Jun 26, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 23, 2023 •
edited
Loading

Add three new configuration options, see the API docs for their description:

  • max_blocks
  • provider_timeout
  • global_timeout

bajtos added 4 commits June 23, 2023 13:39
@bajtos
feat: expose additional Lassie configuration options
8bd0341 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
better docs, fix tests
8aa09f6 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
more cleanup
7799d74 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
fix grammar
c059ccd 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber June 26, 2023 14:47
@bajtos bajtos marked this pull request as ready for review June 26, 2023 14:47
juliangruber
juliangruber approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

@bajtos bajtos enabled auto-merge (squash) June 26, 2023 15:04
@bajtos bajtos disabled auto-merge June 26, 2023 15:04
@bajtos bajtos enabled auto-merge (squash) June 26, 2023 15:04
@bajtos bajtos merged commit 8502613 into main Jun 26, 2023
@bajtos bajtos deleted the feat-more-config-options branch June 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bajtos @juliangruber