Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #661: replaced var with const #669

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Fixes #661: replaced var with const #669

merged 2 commits into from
Jan 31, 2019

Conversation

andrewkoung
Copy link
Contributor

@andrewkoung andrewkoung commented Jan 24, 2019 •
edited
Loading

Changed the every keyword "var" in the whole file to use const.

@codecov-io
Copy link

codecov-io commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #669 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...f835d73. Read the comment docs.

humphd
humphd requested changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. I see one more that needs to get fixed on line 93.

Also, can you add 'use strict'; to the top?

@andrewkoung
Update fs.symlink.spec.js
f835d73 
fixed line 93 and added strict mode
@andrewkoung
Copy link
Contributor Author

@humphd changes made

jadach1
jadach1 reviewed Jan 27, 2019
View reviewed changes
Copy link
Contributor

@jadach1 jadach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Everything looks to be in order.

jatinkumarg
jatinkumarg reviewed Jan 27, 2019
View reviewed changes
Copy link
Contributor

@jatinkumarg jatinkumarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I have also added 'use strict' at the top of the fs.readdir.spec.js file.

jadach1
jadach1 approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@jadach1 jadach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

humphd
humphd approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now.

@humphd humphd merged commit 4de0bbf into filerjs:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatinkumarg jatinkumarg jatinkumarg left review comments

@jadach1 jadach1 jadach1 approved these changes

@humphd humphd humphd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewkoung @codecov-io @humphd @jatinkumarg @jadach1