Fix Issue 684: Replace var with const, let in filer/tests/spec/filer.buffer.spec.js #697
Conversation
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 86.71% 86.63% -0.08%
==========================================
Files 16 16
Lines 1746 1736 -10
==========================================
- Hits 1514 1504 -10
Misses 232 232
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@humphd, @rscotchmer should package-lock.json be updated in PR?
There was a problem hiding this comment.
This is looking really good. A few things we can do to finish it.
-
let's roll back the change to
package-lock.json, since it's not really part of this fix. You can do that withgit checkout master package-lock.json. We can update that file in another separate PR. -
You can swap all your
lettoconstbelow. -
Can you add a newline at the end of the file?
Let me know when you've fixed this and pushed your changes, and I'll re-review.
|
@ApolllonDev yes, we can do that in a different PR. |
…r.buffer.spec.js, added new line at the end of filer.buffer.spec.js
|
Thank you, @humphd @ApolllonDev; just made the requested changes! Let me know if there's anything else that ought to be fixed. |
Replaced instances of var with const and let, depending on the variable being declared. Const was used for the requires, whose values should not change. Let was used for everything else, as the values were permutable and accessed only within the scope they were declared in.