Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated environment.js to use const insted of var for constant property #709

Merged
merged 2 commits into from
Jan 31, 2019
Merged

updated environment.js to use const insted of var for constant property #709

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
616b021
updated environment.js to use const insted of var for constant property
Jan 30, 2019
d6ee542
Added use strict
Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shell/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var defaults = require('../constants.js').ENVIRONMENT;
const defaults = require('../constants.js').ENVIRONMENT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think you should also include 'use strict'; to the head of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Thanks. :) @vrozin


module.exports = function Environment(env) {
env = env || {};
Expand Down