Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #708: Added 'use strict' and replaced var with let/const in fs.appendFile.spec.js #713

Merged
merged 7 commits into from
Jan 31, 2019
Merged

Fixed #708: Added 'use strict' and replaced var with let/const in fs.appendFile.spec.js #713

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
214977d
Add files via upload
DavidLi119 Jan 30, 2019
ca9a923
Add files via upload
DavidLi119 Jan 30, 2019
3a4e26f
Revert "Add files via upload"
DavidLi119 Jan 30, 2019
36d23ff
Update fs.appendFile.spec.js
DavidLi119 Jan 30, 2019
8aa5cbb
s
DavidLi119 Jan 31, 2019
8bc47dd
Revert "s"
DavidLi119 Jan 31, 2019
64ddef1
Changed all `let` to `const`
DavidLi119 Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 42 additions & 40 deletions tests/spec/fs.appendFile.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
var util = require('../lib/test-utils.js');
var expect = require('chai').expect;
'use strict';

const util = require('../lib/test-utils.js');
const expect = require('chai').expect;

describe('fs.appendFile', function() {
const contents = 'This is a file.';

beforeEach(function(done) {
util.setup(function() {
var fs = util.fs();
let fs = util.fs();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be const

fs.writeFile('/myfile', contents, function(error) {
if(error) throw error;
done();
Expand All @@ -16,13 +18,13 @@ describe('fs.appendFile', function() {
afterEach(util.cleanup);

it('should be a function', function() {
var fs = util.fs();
let fs = util.fs();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let fs = util.fs();
const fs = util.fs();

expect(fs.appendFile).to.be.a('function');
});

it('should append a utf8 file without specifying utf8 in appendFile', function(done) {
var fs = util.fs();
var more = ' Appended.';
let fs = util.fs();
const more = ' Appended.';

fs.appendFile('/myfile', more, function(error) {
if(error) throw error;
Expand All @@ -36,8 +38,8 @@ describe('fs.appendFile', function() {
});

it('should append a utf8 file with "utf8" option to appendFile', function(done) {
var fs = util.fs();
var more = ' Appended.';
let fs = util.fs();
const more = ' Appended.';

fs.appendFile('/myfile', more, 'utf8', function(error) {
if(error) throw error;
Expand All @@ -51,8 +53,8 @@ describe('fs.appendFile', function() {
});

it('should append a utf8 file with {encoding: "utf8"} option to appendFile', function(done) {
var fs = util.fs();
var more = ' Appended.';
let fs = util.fs();
const more = ' Appended.';

fs.appendFile('/myfile', more, { encoding: 'utf8' }, function(error) {
if(error) throw error;
Expand All @@ -66,12 +68,12 @@ describe('fs.appendFile', function() {
});

it('should append a binary file', function(done) {
var fs = util.fs();
let fs = util.fs();

// String and utf8 binary encoded versions of the same thing: 'This is a file.'
var binary = Buffer.from([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46]);
var binary2 = Buffer.from([32, 65, 112, 112, 101, 110, 100, 101, 100, 46]);
var binary3 = Buffer.from([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46,
const binary = Buffer.from([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46]);
const binary2 = Buffer.from([32, 65, 112, 112, 101, 110, 100, 101, 100, 46]);
const binary3 = Buffer.from([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46,
32, 65, 112, 112, 101, 110, 100, 101, 100, 46]);

fs.writeFile('/mybinaryfile', binary, function(error) {
Expand All @@ -90,9 +92,9 @@ describe('fs.appendFile', function() {
});

it('should follow symbolic links', function(done) {
var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.';
let fs = util.fs();
const contents = 'This is a file.';
const more = ' Appended.';

fs.symlink('/myfile', '/myFileLink', function (error) {
if (error) throw error;
Expand All @@ -110,7 +112,7 @@ describe('fs.appendFile', function() {
});

it('should work when file does not exist, and create the file', function(done) {
var fs = util.fs();
let fs = util.fs();

fs.appendFile('/newfile', contents, { encoding: 'utf8' }, function(error) {
expect(error).not.to.exist;
Expand All @@ -124,8 +126,8 @@ describe('fs.appendFile', function() {
});

it('should accept numbers and append them to the file', function(done) {
var fs = util.fs();
var more = 10000;
let fs = util.fs();
const more = 10000;

fs.appendFile('/myfile', more, 'utf8', function(error) {
if(error) throw error;
Expand All @@ -142,7 +144,7 @@ describe('fs.appendFile', function() {
describe('fs.promises.appendFile', function() {
beforeEach(function(done) {
util.setup(function() {
var fs = util.fs();
let fs = util.fs();
return fs.promises.writeFile('/myfile', 'This is a file.', { encoding: 'utf8' })
.then(done)
.catch(done);
Expand All @@ -151,47 +153,47 @@ describe('fs.promises.appendFile', function() {
afterEach(util.cleanup);

it('should be a function', function() {
var fs = util.fs();
let fs = util.fs();
expect(fs.promises.appendFile).to.be.a('function');
});

it('should append a utf8 file without specifying utf8 in appendFile', function() {
var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.';
let fs = util.fs();
const contents = 'This is a file.';
const more = ' Appended.';

return fs.promises.appendFile('/myfile', more)
.then(() => fs.promises.readFile('/myfile', 'utf8'))
.then(data => expect(data).to.equal(contents + more));
});

it('should append a utf8 file with "utf8" option to appendFile', function() {
var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.';
let fs = util.fs();
const contents = 'This is a file.';
const more = ' Appended.';

return fs.promises.appendFile('/myfile', more, 'utf8')
.then(() => fs.promises.readFile('/myfile', 'utf8'))
.then(data => expect(data).to.equal(contents + more));
});

it('should append a utf8 file with {encoding: "utf8"} option to appendFile', function() {
var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.';
let fs = util.fs();
const contents = 'This is a file.';
const more = ' Appended.';

return fs.promises.appendFile('/myfile', more, { encoding: 'utf8' })
.then(() => fs.promises.readFile('/myfile', { encoding: 'utf8' }))
.then(data => expect(data).to.equal(contents + more));
});

it('should append a binary file', function() {
var fs = util.fs();
let fs = util.fs();

// String and utf8 binary encoded versions of the same thing: 'This is a file.'
var binary = new Buffer([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46]);
var binary2 = new Buffer([32, 65, 112, 112, 101, 110, 100, 101, 100, 46]);
var binary3 = new Buffer([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46,
const binary = new Buffer([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46]);
const binary2 = new Buffer([32, 65, 112, 112, 101, 110, 100, 101, 100, 46]);
const binary3 = new Buffer([84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 102, 105, 108, 101, 46,
32, 65, 112, 112, 101, 110, 100, 101, 100, 46]);

return fs.promises.writeFile('/mybinaryfile', binary)
Expand All @@ -201,9 +203,9 @@ describe('fs.promises.appendFile', function() {
});

it('should follow symbolic links', function() {
var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.';
let fs = util.fs();
const contents = 'This is a file.';
const more = ' Appended.';

return fs.promises.symlink('/myfile', '/myFileLink')
.then(() => fs.promises.appendFile('/myFileLink', more, 'utf8'))
Expand All @@ -212,8 +214,8 @@ describe('fs.promises.appendFile', function() {
});

it('should work when file does not exist, and create the file', function() {
var fs = util.fs();
var contents = 'This is a file.';
let fs = util.fs();
const contents = 'This is a file.';

return fs.promises.appendFile('/newfile', contents, { encoding: 'utf8' })
.then(() => fs.promises.readFile('/newfile', 'utf8'))
Expand Down