Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update errors.spec.js #718

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Update errors.spec.js #718

merged 2 commits into from
Feb 5, 2019

Conversation

PrimeN
Copy link
Contributor

@PrimeN PrimeN commented Jan 30, 2019

Updating errors.spec.js to use const/let appropriately instead of var.

@PrimeN
Update errors.spec.js
a1cddb6 
Updating errors.spec.js to use const/let appropriately instead of var.
@codecov-io
Copy link

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...a1cddb6. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...7c9374d. Read the comment docs.

humphd
humphd requested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I noticed a few things you can fix, and left some comments. Also note: for all the uses of let they could actually be const, but I only mentioned the first two.

tests/spec/errors.spec.js Outdated Show resolved Hide resolved
tests/spec/errors.spec.js Outdated Show resolved Hide resolved
tests/spec/errors.spec.js Outdated Show resolved Hide resolved
@PrimeN
Update errors.spec.js
7c9374d 
- Changed corrected 'using' to 'use'.
- Changed 'let' to 'const' becuase the're not being changed during the function scope.
humphd
humphd approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great.

@humphd
Copy link
Contributor

humphd commented Feb 5, 2019

@PrimeN one tip: you're fixing issue #664, so in your PR you can mention it by saying Fixes #664 and then GitHub will auto-close your issue when the PR gets merged. Next time!

@humphd humphd merged commit 9d4b264 into filerjs:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrimeN @codecov-io @humphd