-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 627 #746
Merged
Merged
Issue 627 #746
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e3da133
added test to fs.readlink.spec.js
CDNRae 6cfed81
Merge branch 'master' of github.com:filerjs/filer
CDNRae e770ad0
Merge branch 'master' of github.com:filerjs/filer
CDNRae 49d430a
added test for fs.write() to try and write a file opened without the …
CDNRae 917d398
added test to fs.write() that attempts to write with a buffer that is…
CDNRae 006e181
added a test to fs.write() to try and write to a file that doesn't exist
CDNRae 01f3f1c
added more specific summary of test for writing to buffer when length…
CDNRae f04ca91
Adjusted the message on line 69 to be more clear
CDNRae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fs.write
takes anfd
, so passing it a filepath as astring
is really testing what we do when we don't pass anfd
. If I do this in node, it throws. Probably returningEBADF
is OK here, since it literally is a bad file descriptor.That said, let's adjust the message on line 69 to be more clear:
it('should fail if given a file path vs. an fd'