Improvements to work done by @tsvietOK (#562)

* Fixed terminals json deserialization during second app start

After first install and start app it working fine, but during second start it crashed. Reason is different models of terminals.json in Assets folder and serialized json(after checking for wt.exe in 4e5f739)

* Fix WIndows Terminal starting when press Open in Terminal in root folder

* Prevent exception from unwanted state by handling serialization exception

Co-authored-by: Vladyslav <tsvetkov_vlad@ukr.net>

Files/View Models/SettingsViewModel.cs

@@ -307,30 +307,41 @@ private async void LoadTerminalApps()
             }
 
             var content = await FileIO.ReadTextAsync(file);
+            TerminalFileModel terminalsFileModel = null;
+            try
+            {
+                terminalsFileModel = JsonConvert.DeserializeObject<TerminalFileModel>(content);
+            }
+            catch (JsonSerializationException)
+            {
+                var defaultFile = StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appx:///Assets/terminal/terminal.json"));
 
-            var terminals = JsonConvert.DeserializeObject<TerminalFileModel>(content).Terminals;
+                file = await localSettingsFolder.CreateFileAsync("terminal.json", CreationCollisionOption.ReplaceExisting);
+                await FileIO.WriteBufferAsync(file, await FileIO.ReadBufferAsync(await defaultFile));
+                var defaultContent = await FileIO.ReadTextAsync(file);
+                terminalsFileModel = JsonConvert.DeserializeObject<TerminalFileModel>(defaultContent);
 
-            Terminals = terminals;
+            }
 
             // Ensure Windows Terminal is not already in List
-            if (Terminals.FirstOrDefault(x => x.Path.Equals("wt.exe", StringComparison.OrdinalIgnoreCase)) == null)
+            if (terminalsFileModel.Terminals.FirstOrDefault(x => x.Path.Equals("wt.exe", StringComparison.OrdinalIgnoreCase)) == null)
             {
                 PackageManager packageManager = new PackageManager();
                 var terminalPackage = packageManager.FindPackagesForUser(string.Empty, "Microsoft.WindowsTerminal_8wekyb3d8bbwe");
                 if (terminalPackage != null)
                 {
-                    terminals.Add(new TerminalModel()
+                    terminalsFileModel.Terminals.Add(new TerminalModel()
                     {
-                        Id = terminals.Count + 1,
+                        Id = terminalsFileModel.Terminals.Count + 1,
                         Name = "Windows Terminal",
                         Path = "wt.exe",
-                        arguments = "-d \"{0}\"",
+                        arguments = "-d {0}",
                         icon = ""
                     });
-                    await FileIO.WriteTextAsync(file, JsonConvert.SerializeObject(terminals, Formatting.Indented));
-                    Terminals = terminals;
+                    await FileIO.WriteTextAsync(file, JsonConvert.SerializeObject(terminalsFileModel, Formatting.Indented));
                 }
             }
+            Terminals = terminalsFileModel.Terminals;
         }
 
         private IList<TerminalModel> _Terminals = null;