Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: filestags.json doesn't export probably #14995

Closed
Josh65-2201 opened this issue Mar 19, 2024 · 2 comments · Fixed by #15011
Closed

Bug: filestags.json doesn't export probably #14995

Josh65-2201 opened this issue Mar 19, 2024 · 2 comments · Fixed by #15011
Labels
area - tags Features or bug reports for Tags good first issue Good issue for new contributors to get started with

Comments

@Josh65-2201
Copy link
Member

Josh65-2201 commented Mar 19, 2024 •
edited
Loading

Description

The exported file is missing the line "FileTagList": [ and the closing bracket at the bottom which stops it from importing and resets.

Steps To Reproduce

  1. Create a tag
  2. Export from Files settings > Advanced > Export
  3. Import settings
  4. Restart Files
  5. See the created tag is missing

Requirements

  • Fix file formatting for export zip

Files Version

3.3.0.0

Windows Version

10.0.22621.3155

Log File
@Josh65-2201 Josh65-2201 added bug area - tags Features or bug reports for Tags labels Mar 19, 2024
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Mar 19, 2024
@Arnav-2004
Copy link
Contributor

Hi @Josh65-2201, I would like to work on this issue. I found out that the ExportSettings method within the FileTagsSettingsService class is missing "FileTagList" line and the closing bracket in the exported JSON data.

@Josh65-2201
Copy link
Member Author

Thanks, please open a PR when ready and link it to this issue

@Arnav-2004 Arnav-2004 mentioned this issue Mar 20, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area - tags Features or bug reports for Tags good first issue Good issue for new contributors to get started with
Projects
Files task board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Fixed an issue with exporting tags Arnav-2004/Files
3 participants
@Josh65-2201 @yaira2 @Arnav-2004