Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue with exporting tags #15011

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Arnav-2004
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: filestags.json doesn't export probably  #14995

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Create a tag
    2. Export from Files settings > Advanced > Export
    3. Import settings
    4. Restart Files

Screenshots (optional)
Add screenshots here.

@0x5bfa
Copy link
Member

0x5bfa commented Mar 20, 2024

This won't be reviewed until the issue is approved(ready for build tagging). Please read the contribution guideline mentioned in the README.md before working on contribution. Unless, your contribution might be rejected.

@Arnav-2004
Copy link
Contributor Author

This won't be reviewed until the issue is approved(ready for build tagging). Please read the contribution guideline mentioned in the README.md before working on contribution. Unless, your contribution might be rejected.

Status: 🔖 Ready to build
Priority: 🌋 Urgent
Size:🐇 Small

Sorry for inconvenience, correct me if I am wrong.

@0x5bfa
Copy link
Member

0x5bfa commented Mar 20, 2024

Omg, I see GitHub with GitHub mobile and project modification are not shown on the app. Apologies for that, I'll review now.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple formatting issues; otherwise, looks good to me.

@yaira2 yaira2 requested a review from d2dyno1 March 20, 2024 14:52
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 20, 2024
@yaira2 yaira2 changed the title Fix: filestags.json doesn't export probably Fix: Fixed an issue with exporting tags Mar 20, 2024
@yaira2 yaira2 merged commit a9c24b4 into files-community:main Mar 20, 2024
6 checks passed
@Arnav-2004 Arnav-2004 deleted the bug/filestags branch March 20, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: filestags.json doesn't export probably
3 participants