Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added "send to" menu when right clicking a file #10986

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 11, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Feature: Added "send to" menu when right clicking Feature: Added "send to" menu when right clicking a file Jan 11, 2023
@yaira2 yaira2 requested a review from gave92 January 11, 2023 15:38
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me

@gave92
Copy link
Member

gave92 commented Jan 12, 2023

Can't test this but send to menu was turned off because it locks the app if you have disconnected network drives iirc. Haven't checked in a long time.

@yaira2
Copy link
Member Author

yaira2 commented Jan 15, 2023

@gave92 are you comfortable releasing to preview to see if this is still an issue?

@gave92
Copy link
Member

gave92 commented Jan 15, 2023

Fairly sure it's still an issue but probably impacts only few users.

@yaira2 yaira2 merged commit 94c8e57 into main Jan 15, 2023
@yaira2 yaira2 deleted the ya/SendTo branch January 15, 2023 21:12
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the "Send to" option
3 participants