Feature: Added support for reordering items in the sidebar

[hecksmosis]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: Add back ability to reorder pinned items #11199

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

[hecksmosis]

The Glyph currently used for the icon in the items needs to be changed, does anyone know of a better icon to use there?

[yaira2]

Which icon?

[yaira2]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ferrariofilippo]

Everything seems to work in debug mode, but there are two problems:

• If I run Files without debug mode, half the time I use this feature, the app crashes. Nothing useful is logged.
• We are wasting time (and space) writing the same things in the logs twice
  

[hecksmosis]

Everything seems to work in debug mode, but there are two problems:

• If I run Files without debug mode, half the time I use this feature, the app crashes. Nothing useful is logged.
• We are wasting time (and space) writing the same things in the logs twice
  

Yes, I forgot to remove the logs, they are totally unnecessary

[hecksmosis]

Do you have any recent folders in the quick access widget? (I haven't tried it with folders that are not pinned because I recently reset the sidebar items)

[hecksmosis]

By the way, I can't reproduce the crashes on my end, any idea why they could be happening?

[yaira2]

Two things I noticed

1. Clicking a pinned item often triggers the drag event even when it was just a regular click
2. It's hard to drag and drop to the right area without accidentally moving the folder into one of the other pinned items. File Explorer has a visual indicator to show where the item is being dropped but I'm not sure we can do that with the sidebar.

[drasticactions]

Since you at-replied me this ended up in my email. I looked at your PR and I'm not sure you used my workaround, which may speak to @yaira2's issue.

For microsoft/microsoft-ui-xaml#3290, I attach the "DragStarting" event to the underling "NavigationViewItemPresenter". That's a "workaround" (Hack) that lets me attach the same normal events that would be allowed for Elements to the NavigationItem. You can see it implemented here,https://github.com/drasticactions/MauiFeed/blob/main/src/MauiFeed.WinUI/Views/FeedSidebarItem.cs#L237-L252

In short, you would implement it the same way you would have to NavigationViewItem, but instead attach those events to the NavigationViewItemPresenter. Eventually, when the underling issue is fixed, you should be able to add those events back to the NavigationViewItem.

[hecksmosis]

Since you at-replied me this ended up in my email. I looked at your PR and I'm not sure you used my workaround, which may speak to @yaira2's issue.

For microsoft/microsoft-ui-xaml#3290, I attach the "DragStarting" event to the underling "NavigationViewItemPresenter". That's a "workaround" (Hack) that lets me attach the same normal events that would be allowed for Elements to the NavigationItem. You can see it implemented here,https://github.com/drasticactions/MauiFeed/blob/main/src/MauiFeed.WinUI/Views/FeedSidebarItem.cs#L237-L252

In short, you would implement it the same way you would have to NavigationViewItem, but instead attach those events to the NavigationViewItemPresenter. Eventually, when the underling issue is fixed, you should be able to add those events back to the NavigationViewItem.

True, I ended up not really using your workaround (sorry for the ping)

[ferrariofilippo]

By the way, I can't reproduce the crashes on my end, any idea why they could be happening?

I have no idea why that is happening:

Crash.mp4

It seems that Favorites section is refreshed twice when you pin/unpin an item (I don't know if this behaviour is related with this PR)

[ferrariofilippo]

Should be done now (hopefully no more bugs)

Everything is fine now 👍

[hecksmosis]

I changed the ListViewItem to Grid and it now works fine, this is ready

[yaira2]

Should we display a progress ring and delay closing the dialog until the changes are saved?

[hecksmosis]

I don't think this is necessary, this is probably not going to be used very regularly, just occasionally

[yaira2]

The reason I think it's worth doing this (it's not a blocker) is that the app freezes and it's not exactly clear to the user what's happening in the background.

[hecksmosis]

Oh ok

[yaira2]

LGTM

[hecksmosis]

Should I open a PR with the progress ring?

[yaira2]

If you don't mind, thanks!

[Wolfarelli]

The reorder dialog seems to need a scroll bar for favorites lists longer than 15 items; mouse wheel doesn't work neither.

[yaira2]

@Wolfarelli can you open a feature request for this?