Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add pinned items to taskbar jumplist #11632

Merged
merged 10 commits into from
Mar 12, 2023

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Mar 9, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member

yaira2 commented Mar 9, 2023

Unpinning an item in File Explorer isn't updating the jumplist (even when Files is open).

@hecksmosis
Copy link
Contributor Author

Unpinning an item in File Explorer isn't updating the jumplist (even when Files is open).

Also, just noticed that the quick access widget doesn't update either, will fix it

@hecksmosis
Copy link
Contributor Author

Fixed

@yaira2
Copy link
Member

yaira2 commented Mar 9, 2023

Unpinning an item in File Explorer updates the jumplist but it hides recent folders from the home page.

@hecksmosis
Copy link
Contributor Author

hecksmosis commented Mar 10, 2023

Unpinning an item in File Explorer updates the jumplist but it hides recent folders from the home page.

I can't reproduce this, I don't know why it's happening

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2023

  1. Open Files to the home page
  2. Open File Explorer and right click a pinned item in Quick Access
  3. Unpin the item and notice that recent folders were removed from the list in Files.

@hecksmosis
Copy link
Contributor Author

screen-capture.webm
I still can't reproduce it

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2023

It looks like you don't have recent folders at all on your device.

@hecksmosis
Copy link
Contributor Author

Oh sorry, misunderstood you, thought you talked about pinned folders. I'll try to fix it, but I probably won't be able to test it since I manually reset the pinned items a while ago

@hecksmosis
Copy link
Contributor Author

This fix should work, can someone test it?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 12, 2023
@yaira2 yaira2 merged commit bdf6a81 into files-community:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Sync pinned favorites with taskbar jumplist
3 participants