Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where checkboxes might remain visible #12104

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix: Fixed issue where checkboxes might remain visible #12104

merged 1 commit into from
Apr 17, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Quick cursor movement may cause checkboxes to remain visible #12100

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Fixed issue where checkboxes may remain visible Fix: Fixed issue where checkboxes might remain visible Apr 17, 2023
@yaira2 yaira2 requested a review from marcelwgn April 17, 2023 17:19
marcelwgn
marcelwgn approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the way you fixed this! LGTM.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 17, 2023
@yaira2 yaira2 merged commit c9962cd into files-community:main Apr 17, 2023
@hishitetsu hishitetsu deleted the FixCheckbox branch April 18, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Quick cursor movement may cause checkboxes to remain visible
3 participants
@hishitetsu @marcelwgn @yaira2