Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reduced tooltip size when only the drive name is available #12231

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Apr 29, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes None

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Hover a drive such as C:\, see that the tooltip looks as before
    3. Hover Network folder or any other that has no detail

Screenshots (optional)
Before/After
2 3

Before/After
5 4

@yaira2 yaira2 changed the title Fix: reduce tooltip size when only the drive name is available Fix: Reduced tooltip size when only the drive name is available Apr 30, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 30, 2023

@ferrariofilippo can you verify the tooltip looks the same when a regular drive is hovered over?

@ferrariofilippo
Copy link
Contributor Author

@ferrariofilippo can you verify the tooltip looks the same when a regular drive is hovered over?

Done

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 30, 2023
@yaira2 yaira2 merged commit 604a0ef into files-community:main Apr 30, 2023
@ferrariofilippo ferrariofilippo deleted the Sidebar_Tooltips branch April 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants