Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Git Integration - Phase 4 #12439

Merged
merged 14 commits into from
May 30, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Git integration #11014

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Navigate to a git directory
    3. Pull changes

Screenshots (optional)
image

@ferrariofilippo ferrariofilippo marked this pull request as draft May 23, 2023 20:18
@ferrariofilippo ferrariofilippo marked this pull request as ready for review May 25, 2023 15:27
hecksmosis
hecksmosis previously approved these changes May 26, 2023
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me! (sorry for submitting the review today, I forgot to submit yesterday)

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented May 27, 2023

I'll need some more time to implement support for proxy Nevermind, it's not supported yet

yaira2
yaira2 previously approved these changes May 29, 2023
@yaira2 yaira2 requested a review from 0x5bfa May 29, 2023 16:41
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of the codebase quality, LGTM! Thank you🎉

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 30, 2023
@yaira2 yaira2 merged commit 1b24eb0 into files-community:main May 30, 2023
@ferrariofilippo ferrariofilippo deleted the Git_Phase_4 branch May 30, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants