Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where middle clicking selected folders would cause crash #12683

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 21, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Crash when opening highlighted folder in new tab #12613...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select folder
    2. Middle click selected folder to open it in new tab
    3. Confirm it doesn't cause a crash
    4. Test in all the layouts

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix: Fixed issue where middle clicking selected folders would crash app Fix: Fixed issue where middle clicking selected folders would cause crash Jun 21, 2023
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tiles layout doesn't crash, but there is a glitch that leaves the text box when you go back to the original tab, so we should do the same fix as below.

src/Files.App/Views/LayoutModes/StandardLayoutMode.cs Outdated Show resolved Hide resolved
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 yaira2 requested a review from hishitetsu June 22, 2023 13:45
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 22, 2023
@yaira2 yaira2 merged commit 716eec0 into main Jun 22, 2023
@yaira2 yaira2 deleted the ya/FixMiddleClick branch June 22, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Crash when opening highlighted folder in new tab
2 participants