Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Added empty view models of Widgets #14922

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 8, 2024

Summary

As the title. This is 0st stage of introduction of view models to Widgets.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Code Quality: Use RichCommand for widget items #14760
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

@yaira2
Copy link
Member

yaira2 commented Mar 8, 2024

Should we also register the ViewModels to the views?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2024

This phased approach will allow us to review each change separately, making code review faster and hopefully reduce the risk of new issues.

@yaira2 yaira2 merged commit 929dc5f into files-community:main Mar 10, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 10, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Add-WidgetVMs branch March 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants