Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MD5Hash Error (bug fix) #4121

Closed
wants to merge 6 commits into from
Closed

MD5Hash Error (bug fix) #4121

wants to merge 6 commits into from

Conversation

oleitao
Copy link
Contributor

@oleitao oleitao commented Mar 16, 2021

MD5Hash Error (bug fix) [2914]

@yaira2 yaira2 requested a review from tsvietOK March 16, 2021 23:28
tsvietOK
tsvietOK suggested changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@tsvietOK tsvietOK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleitao This fix produces another bug. Open properties for some file, wait until md5 hash will be calculated
image
go to Details tab and go back.
image
There will be wrong md5 hash (always d41d8cd98f00b204e9800998ecf8427e, which is a hash of empty file).

@tsvietOK tsvietOK added changes requested Changes are needed for this pull request and removed needs - code review labels Mar 17, 2021
@oleitao
Copy link
Contributor Author

oleitao commented Mar 17, 2021

@oleitao This fix produces another bug. Open properties for some file, wait until md5 hash will be calculated
image
go to Details tab and go back.
image
There will be wrong md5 hash (always d41d8cd98f00b204e9800998ecf8427e, which is a hash of empty file).

@tsvietOK After some tests the hash string is refreshed fine each time i switch between 'General' and 'Details' tabs. Please check if that bug is corrected.

@oleitao oleitao requested a review from tsvietOK March 21, 2021 18:05
@oleitao
Copy link
Contributor Author

oleitao commented Mar 21, 2021

@tsvietOK what about merge current issue [4121] with [3722]?

@oleitao oleitao mentioned this pull request Mar 25, 2021
Closed
3 tasks
@yaira2 yaira2 requested a review from gave92 March 30, 2021 17:06
@tsvietOK
Copy link
Contributor

tsvietOK commented Apr 2, 2021

@tsvietOK what about merge current issue [4121] with [3722]?

@oleitao I think it is great idea!

@yaira2
Copy link
Member

yaira2 commented Apr 14, 2021

@oleitao Can we get an update on this PR?

@oleitao
Copy link
Contributor Author

oleitao commented Apr 14, 2021

@oleitao Can we get an update on this PR?

@yaichenbaum yes

@yaira2
Copy link
Member

yaira2 commented Apr 27, 2021

@oleitao Great! Please reopen this PR whenever you're ready to continue working on it 🙂

@yaira2 yaira2 closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsvietOK tsvietOK Awaiting requested review from tsvietOK

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
changes requested Changes are needed for this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleitao @tsvietOK @yaira2