Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups and minor improvements to Code #531

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Cleanups and minor improvements to Code #531

merged 4 commits into from
Apr 8, 2020

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Apr 8, 2020 •
edited
Loading

Does the following:

  • Removes unused controls
  • Gets localized version of "File folder" type for folders through StorageFolder.DisplayType
  • Adds PrimaryItemAttribute to ListedItem for easy distinction between files and folders
  • Improves reliability of item right-click

@lukeblevins lukeblevins changed the base branch from master to develop April 8, 2020 00:41
@lukeblevins lukeblevins requested a review from yaira2 April 8, 2020 00:41
@lukeblevins lukeblevins linked an issue Apr 8, 2020 that may be closed by this pull request
right-clicking on an item in a folder crashes files uwp when not selecting the item first #532
Closed
@lukeblevins lukeblevins merged commit 8ff8736 into develop Apr 8, 2020
@lukeblevins lukeblevins deleted the cleanup branch April 8, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

right-clicking on an item in a folder crashes files uwp when not selecting the item first
2 participants
@lukeblevins @yaira2