Improve tab behavior when in special folders #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compares the start of current folder path with the special folder paths, thus allowing nested folders to still be correctly detected as Pictures or Music folders Also fixes a mild spelling error
lukeblevins
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compares the start of the folder path with the special folder paths, instead of a direct comparison. This allows for nested folders to be recognized as part of the "special folders" as well.
Also fixes a spelling error "Naviagtion" and removes extraneous assignment of
SidebarSelectedItemwhich is already done in thesetfunction ofWorkingDirectory.Resolves #525