Added context menu options to rearrange Favorites item

[BanCrash]

Opening this as a draft since there is still a visual bug that I didn't figure out how to fix it.

I will try to solve this, but since the timeline for the V2 is almost done I suggest to set a timeline also for this, and if I can't solve this issue since it's only visual merge this and open a new issue to fix it in the future.

The issue is that when you move the actual selected item, it will stay as selected even if you select another one: partially fixed, now it will work as expected except that moved item won't have the selection pill.

Resolved / Related Issues

• Related Add the ability to rearrange pinned items  #1069

Details of Changes

• Added context menu options to rearrange Favorites item (right click on an item to have to option to move it up/down/top/bottom).

Current limitations

• Not available for Home nor Recycle bin. Maybe in a future PR.
• There is a bug when you move the actual selected item, that it will keep it selected even if you switch to another selected item until you select it back again. There is a bug that doesn't show the selection pill when you change the actual selected item.

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)

[BanCrash]

I think the bug I've found it's not from Files but from WinUi. I've found this similar issue, though not exactly the same:
microsoft/microsoft-ui-xaml#2845

And also this that I'm not sure neither if it's the same: microsoft/microsoft-ui-xaml#3015

[R3voA3]

While I like the idea of being able to change the order of appearance, wouldn't it be more intuitive to just be able to drag and drop the items? With the context menu, rearranging many items can become tedious.

[BanCrash]

While I like the idea of being able to change the order of appearance, wouldn't it be more intuitive to just be able to drag and drop the items? With the context menu, rearranging many items can become tedious.

My idea would be to have both ways and everyone choose whatever option they want (or even sometimes one and sometimes the other). But currently there is a bug on WinUI that doesn't allow to have the drag and drop functionality. When that bug is fixed we can have also that way.

[R3voA3]

While I like the idea of being able to change the order of appearance, wouldn't it be more intuitive to just be able to drag and drop the items? With the context menu, rearranging many items can become tedious.

My idea would be to have both ways and everyone choose whatever option they want (or even sometimes one and sometimes the other). But currently there is a bug on WinUI that doesn't allow to have the drag and drop functionality. When that bug is fixed we can have also that way.

Sounds great!

[yaira2]

While I like the idea of being able to change the order of appearance, wouldn't it be more intuitive to just be able to drag and drop the items? With the context menu, rearranging many items can become tedious.

As @BanCrash mentioned, drag and drop would be ideal, but until the WinUI issue is resolved, we're implementing this as a workaround.

[gave92]

Nice!