DefaultHttpLoader creates invalid accept header

[aixigo-soffermann]

This line is broken. It should be

        builder.append(";q=0.9,*/*;q=0.1");

Otherwise https://www.w3.org/ns/activitystreams will always return "text/html" instead of "application/ld+json".

You can easily verify this using curl:

curl -i https://www.w3.org/ns/activitystreams -H "accept: application/ld+json;profile="http://www.w3.org/ns/json-ld#context",application/json;q=0.9,*/*;q=0.8"

returns:

HTTP/2 200 
date: Fri, 01 Oct 2021 12:43:05 GMT
content-location: activitystreams.html
vary: negotiate,accept,Accept-Encoding
tcn: choice
last-modified: Mon, 09 Nov 2020 11:09:17 GMT
etag: "9033-5b3aa97d9d140;d3-540ee27e0eec0"
accept-ranges: bytes
content-length: 36915
cache-control: max-age=21600
expires: Fri, 01 Oct 2021 18:43:05 GMT
access-control-allow-origin: *
content-type: text/html; charset=utf-8
x-backend: ssl-mirrors
strict-transport-security: max-age=15552000; includeSubdomains; preload
content-security-policy: upgrade-insecure-requests

...

Whereas

curl -i https://www.w3.org/ns/activitystreams -H "accept: application/ld+json;profile="http://www.w3.org/ns/json-ld#context",application/json;q=0.9,*/*;q=0.1"

returns

HTTP/2 200 
date: Fri, 01 Oct 2021 12:45:42 GMT
content-location: activitystreams.jsonld
vary: negotiate,accept
tcn: choice
last-modified: Mon, 09 Nov 2020 11:09:17 GMT
etag: "1f31-5b3aa97d9d140;d3-540ee27e0eec0"
accept-ranges: bytes
content-length: 7985
cache-control: max-age=21600
expires: Fri, 01 Oct 2021 18:45:42 GMT
access-control-allow-origin: *
content-type: application/ld+json
x-backend: ssl-mirrors
strict-transport-security: max-age=15552000; includeSubdomains; preload
content-security-policy: upgrade-insecure-requests

...

[filip26]

Hi @aixigo-soffermann
thank you for reporting that Please feel free to open PR.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment!