fix: hadolint demands yarn cache clean

filipeforattini · Apr 28, 2022 · ed8736e · ed8736e
1 parent 6119517
commit ed8736e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/scrappers/nodejs.class.js b/src/scrappers/nodejs.class.js
@@ -28,6 +28,11 @@ module.exports = class Nodejs extends Scrapper {
         ? 'package-lock.json' 
         : 'package.json'
 
+    const completeDependencyCommand = [
+      dependencyCommand,
+      hasYarnLock ? 'yarn cache clean' : '',
+    ].join('\\\n\t')
+
     this
       .add('code', {
         cacheKey,
@@ -43,7 +48,7 @@ module.exports = class Nodejs extends Scrapper {
         entrypoint,
         command,
         dockerignore,
-        dependencyCommand,
+        dependencyCommand: completeDependencyCommand,
       })
   }
 }
diff --git a/src/steps/generate-dockerfile.js b/src/steps/generate-dockerfile.js
@@ -5,9 +5,9 @@ const Template = require("../template");
 const stub = `
 # This file was autogenerated at {{generatedAt}}.
 FROM {{image}}:{{tag}}
-MAINTAINER {{maintainer}}
 
 LABEL {{labels}}
+
 ENV {{environemntVariables}}
 
 WORKDIR /app
@@ -25,7 +25,6 @@ module.exports = function (params, writeFile = true) {
   const {
     image,
     tag,
-    maintainer,
     labels = [],
     environemntVariables = [ 'TZ=GMT', 'ENV=development' ],
     generatedAt = new Date().toISOString(),
@@ -40,9 +39,8 @@ module.exports = function (params, writeFile = true) {
     generatedAt,
     image,
     tag,
-    maintainer,
     labels: [
-      `builtAt=${new Date().toISOString().substring(0, 10)}`,
+      `built-at=${new Date().toISOString().substring(0, 10)}`,
     ].concat(labels).join(' \\\n\t'),
     environemntVariables: [].concat(environemntVariables).join(' \\\n\t'),
     dependencyCommand,