Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue of using empty username when searching #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DummyCatz
Copy link

Fixes an issue of using empty username when searching

@filiphanes
Copy link
Owner

thanks
In what situation was empty username problem?

@DummyCatz
Copy link
Author

DummyCatz commented Jul 24, 2023

thanks In what situation was empty username problem?

The public mailboxes don't have owners, so the usernames are empty in this case.

@filiphanes
Copy link
Owner

Why did you choose -?

Could it be solved by changing elastic schema to allow empty user?

I think when user is empty it should be empty or null not short string.

@filiphanes
Copy link
Owner

try setting null_value in elastic schema:
"user": {"type": "keyword", "normalizer": "lowercase", "null_value": ""},

@filiphanes
Copy link
Owner

fts-elastic uses parameter routing=user for faster connection to shard with user's mails.
How should it work in public mailboxes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants