Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-fetch group information #82

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

sehaas
Copy link
Contributor

@sehaas sehaas commented Jan 3, 2025

The bot cannot reply to groups if it was added after startup, since the receiver lookup fails.

Instead of periodically refreshing the groups, the commit checks the group while receiving new messages.
If the group is unknown, _detect_groups() is called before passing the message on.

@Era-Dorta Era-Dorta self-requested a review January 4, 2025 16:56
Copy link
Collaborator

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The code changes look good but the unit testing is failing, I guess because of how the connection is mocked. Could please fix that?

update groups if a message is from an unknown group
@sehaas sehaas requested a review from Era-Dorta January 4, 2025 18:59
Copy link
Collaborator

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for fixing the unit testing too.

@Era-Dorta Era-Dorta merged commit 7b10bb7 into filipre:master Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants