Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bazel_skylib URL #34

Merged
merged 1 commit into from
May 12, 2024
Merged

Fixing bazel_skylib URL #34

merged 1 commit into from
May 12, 2024

Conversation

CauhxMilloy
Copy link
Contributor

  • Adding missing / in the URL for downloading bazel_skylib.

* Adding missing `/` in the URL for downloading `bazel_skylib`.
@CauhxMilloy CauhxMilloy mentioned this pull request May 12, 2024
@CauhxMilloy
Copy link
Contributor Author

CauhxMilloy commented May 12, 2024

Responding to #33 (comment) here:

I think we should just use the regular link to the release archves such as https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz, vs the more "exotic" one. Unless I'm missing something?

These are the links when going to the tags page on GH. See https://github.com/bazelbuild/bazel-skylib/tags (which is the same as the "Source Code" link on the Releases page, https://github.com/bazelbuild/bazel-skylib/releases/tag/1.5.0).
The same URLs are used for links are used in deps.bzl.

@filmil filmil merged commit 4748688 into filmil:main May 12, 2024
3 checks passed
@CauhxMilloy CauhxMilloy deleted the fixingSkylibUrl branch May 12, 2024 18:39
@CauhxMilloy
Copy link
Contributor Author

Now that this is in and master is green again, should a new tag/release be pushed so that latest is passing?

@filmil
Copy link
Owner

filmil commented May 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants