feat(core): Add ingestion support for Tantivy #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements enough of the interface to add documents to the Tantivy index. This is part 2 of the series and is not usable end to end until additional PRs complete. Document additional and removal is covered in this PR. Documents are created by calling a single native method that has many of the built-in fields, such as start and end time, passed as method parameters. Dyanmic fields are passed to the Rust code via a simple binary encoding to reduce JNI overhead.
rfairfax
force-pushed
the
rfairfax/tantivy_p2
branch
from
7e430b9
to
bf797b5
Compare
vishramachandran
previously approved these changes
Aug 13, 2024
core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala
Outdated
Show resolved
Hide resolved
amolnayak311
previously approved these changes
Aug 13, 2024
rfairfax
dismissed stale reviews from amolnayak311 and vishramachandran
via
2b90c68
amolnayak311
approved these changes
Aug 13, 2024
vishramachandran
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements enough of the interface to add documents to the Tantivy index. This is part 2 of the series and is not usable end to end until additional PRs complete.
Document additional and removal is covered in this PR. Documents are created by calling a single native method that has many of the built-in fields, such as start and end time, passed as method parameters. Dyanmic fields are passed to the Rust code via a simple binary encoding to reduce JNI overhead.
Pull Request checklist
New behavior :
Part 2 of Tantivy index support. The functionality is still incomplete and not ready for usage yet.