Improved taint analysis (several bugs fixed, refactoring) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defensive copies and assertions, bug fixes
…d names (and fields) in Taint class simplified
…etting variable indeces and parameter attributes
… passed) Conflicts: plugin/src/main/java/com/h3xstream/findsecbugs/taintanalysis/Taint.java plugin/src/main/java/com/h3xstream/findsecbugs/taintanalysis/TaintMethodSummary.java plugin/src/main/resources/taint-config/methods-summaries.txt
|
Merging should be easy since I have merged your changes |
h3xstream
added a commit
that referenced
this pull request
Sep 15, 2015
Created for the pull request #91 Conflicts: plugin/src/main/java/com/h3xstream/findsecbugs/injection/command/CommandInjectionSource.java plugin/src/main/java/com/h3xstream/findsecbugs/taintanalysis/Taint.java plugin/src/main/resources/taint-config/methods-summaries.txt plugin/src/test/java/com/h3xstream/findsecbugs/injection/command/CommandInjectionDetectorAdvancedTest.java
|
All changes were integrated. I have added a test case for a miss LDAP injection a830a3d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis no longer relies on direct modifications of
Taintinstances inTaintFrameand the code is refactored to be more robust and clear. This pull request should fix issues #80, #82, #83, #84, #85 and #90.There is a change in constructor summaries - now there are two mutable stack indices, since new instances are duplicated before calling a constructor.