Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] 알림 서비스 리팩토링 #392

Merged
merged 14 commits into from
Jun 27, 2024
Merged

[refactor] 알림 서비스 리팩토링 #392

merged 14 commits into from
Jun 27, 2024

Commits on Jun 26, 2024

  1. #350 refactor: List<NotificationCondition>을 제네릭 및 캡슐화

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    113edc4 View commit details
    Browse the repository at this point in the history

  2. #350 refactor: 목표 수익률에 대한 알림 전송 리팩토링

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e1208fa View commit details
    Browse the repository at this point in the history

  3. #350 refactor: FirebaseNotificationProvider 추상화 

    - FirebasePortfolioNotificationProvider 구현
- FirebaseTargetPriceNotificationProvider 구현
    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    91e9e61 View commit details
    Browse the repository at this point in the history

  4. #350 test: 최대 손실율 달성 알림 테스트 추가

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c5d5dab View commit details
    Browse the repository at this point in the history

  5. #350 rename: 변수명 변경

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    59e9afb View commit details
    Browse the repository at this point in the history

  6. #350 refactor: notifyTargetGain 메서드 리팩토링

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d8535a4 View commit details
    Browse the repository at this point in the history

  7. #350 style: saveNotification 메서드 코드 정리

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9ac5817 View commit details
    Browse the repository at this point in the history

  8. #350 refactor: NotificationService의 알림 전송 기능 Notifiable 타입으로 추상화 

    - Notifiable 인터페이스 정의 및 Portfolio 클래스가 구현
    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    23979ca View commit details
    Browse the repository at this point in the history

  9. #350 refactor: TargetPriceNotification 추상화

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9f405c1 View commit details
    Browse the repository at this point in the history

  10. #350 refactor: Service의 리턴타입을 추상화

    @yonghwankim-dev
    yonghwankim-dev committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e44095f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. #350 test: 최대 손실율 알림 테스트 추가

    @yonghwankim-dev
    yonghwankim-dev committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    acf51f5 View commit details
    Browse the repository at this point in the history

  2. #350 refactor: NotificationDispatcher 추가 

    - 해당 객체는 여러 NotificationProvider를 실행하여 다양한 알림 매체에게 알림 전송을 요청합니다.(ex, fcm, kakao, mail...)
    @yonghwankim-dev
    yonghwankim-dev committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4f4a5d8 View commit details
    Browse the repository at this point in the history

  3. #350 style: code 정리

    @yonghwankim-dev
    yonghwankim-dev committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    056c716 View commit details
    Browse the repository at this point in the history

  4. #350 style: 코드 정리

    @yonghwankim-dev
    yonghwankim-dev committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e57c91f View commit details
    Browse the repository at this point in the history