fixes in SDLoraManager #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catwell
force-pushed
the
pr/sd-lora-manager-fixes
branch
from
2bd9eeb
to
edd83ea
Compare
limiteinductive
previously approved these changes
Jan 26, 2024
catwell
force-pushed
the
pr/sd-lora-manager-fixes
branch
from
edd83ea
to
e7f7e84
Compare
limiteinductive
previously approved these changes
Jan 26, 2024
deltheil
previously approved these changes
Jan 26, 2024
|
|
catwell
dismissed stale reviews from deltheil and limiteinductive
via
8acb369
catwell
force-pushed
the
pr/sd-lora-manager-fixes
branch
from
e7f7e84
to
8acb369
Compare
- support _out_0 - sort _in before _out - avoid false positives by only considering suffixes
catwell
force-pushed
the
pr/sd-lora-manager-fixes
branch
from
8acb369
to
dcd50d1
Compare
limiteinductive
previously approved these changes
Jan 26, 2024
(also simplify list comprehension for exclusion list)
limiteinductive
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.