Revert to fork of swift-snapshot-testing
#1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstien
requested review from
a team,
ag12 and
AtishPapa
and removed request for
a team
|
There is an open PR that adds support for non-Metal perceptual diffing that we can follow. |
osanoj
approved these changes
Feb 2, 2023
|
RevenueCat/purchases-ios#3526 |
|
Yes, but we need to pay for those. If we get it approved to pay for it, and we also have access to GPU, we can try to switch. That won't help us on Travis, though, where I believe we don't have any GPUs available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
CircleCI doesn't have any GPUs, which is necessary for the
perceptualPrecisiondiffing that was added to the lib late last year since that method uses Metal.What?
swift-snapshot-testingsubpixelThreshold.Version Change
Minor. No public changes.
UI Changes
None.