Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not create intermediate properties when unsetting a nested value #105

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ssaarela
Copy link
Collaborator

No description provided.

Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
@ssaarela ssaarela force-pushed the feature/fix-path-set branch from 3dc9b1c to f2a98f0 Compare March 19, 2024 15:18
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c76bf49) to head (f2a98f0).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         3563      3565    +2     
  Branches       727       727           
=========================================
+ Hits          3563      3565    +2     
Files Coverage Δ
packages/path/src/Path.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@karlkeskyla karlkeskyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@ssaarela ssaarela merged commit 58d635f into master Mar 20, 2024
6 checks passed
@ssaarela ssaarela deleted the feature/fix-path-set branch March 20, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants