Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker content not centered #15

Closed
nkolba opened this issue Apr 1, 2022 · 11 comments
Closed

Color Picker content not centered #15

nkolba opened this issue Apr 1, 2022 · 11 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nkolba
Copy link
Contributor

nkolba commented Apr 1, 2022

There is an uneven amount of whitespace around the color channel squares - resulting in the picker looking a bit off. Spacing should be even all around. Looks like the amount of spacing on the top and left is correct.

image

@nkolba nkolba added bug Something isn't working good first issue Good for newcomers labels Apr 1, 2022
@Ngoakor12
Copy link

Ngoakor12 commented Apr 2, 2022

Hey, I really wanted to help with these color picker issues. I can't seem to be able to run the app locally. I get this error when running npm run start:directory command:
image

I'm not familiar with typescript and electron but I know my way around react and CSS and I'm sure I could help If I could get the app to run for previews.

Any idea how I can get it working?

@nkolba
Copy link
Contributor Author

nkolba commented Apr 2, 2022

Hey, thanks for looking at the project and jumping in to help with issues!

The directory is just a local node server. Looks like the problem is that you already have something running on the localhost port the directory uses by default (8080). The simplest solution would be to shut down what you already have running on 8080, otherwise, it is relatively simple to change the local directory port. The port is defined in /directory/config.ts.

@Ngoakor12
Copy link

Hey, I managed to get over that and a bunch of more errors but still can't get it working.

After starting the app with npm start and going to localhost:port I get a 404. See screenshoot:
image

Any ideas what could be wrong?

@nkolba
Copy link
Contributor Author

nkolba commented Apr 2, 2022

Looks like I'm missing a default response for the directory. Can you try navigating to localhost:8003/apps ? You should get a JSON response that should look like the below:

image

@Ngoakor12
Copy link

I can. but I was hoping you could help me get a view of some sort so that I can be able to see how my changes reflect in the UI(like the first screenshot of the issue) not a JSON response.

@nkolba
Copy link
Contributor Author

nkolba commented Apr 2, 2022

The directory only provides data to the UI. The UI lives entirely in the Electron part of the project. To see that, run npm start this will run the electron app.

@Ngoakor12
Copy link

That command runs without errors, but no app launches:
image

@nkolba
Copy link
Contributor Author

nkolba commented Apr 2, 2022

just tested with a clean set up.

  • clone the repo and cd electron-fdc3
  • npm i
  • npm run build:directory
  • npm run start:directory
  • in a new terminal,
  • cd electron-fdc3
  • npm start

You should see this launch:

image

Note, it is a standalone electron app, not in a browser.

If you have not worked with electron before, it may be useful to first try a more simple 'hello world' for electron. As this project is a bit more complicated than the average electron app.

@Ngoakor12
Copy link

Hey, I couldn't get it to work, but thanks for trying to help.

I even tried to launch the quick-start electron project from the electron website and kept getting nowhere. I think it has something to do with my machine, I tried it on my current wsl setup and my windows setup with no luck.

@nkolba
Copy link
Contributor Author

nkolba commented Apr 5, 2022

Understood. Some of these things are non-obvious. The upside is that you identified a different issue (no response from the app directory on the ‘/‘ route)! Feel free to come back to this anytime .

@nkolba
Copy link
Contributor Author

nkolba commented Apr 15, 2022

fixed

@nkolba nkolba closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants