Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handlers Refactor #64

Merged
merged 7 commits into from
Oct 6, 2022
Merged

Handlers Refactor #64

merged 7 commits into from
Oct 6, 2022

Conversation

nkolba
Copy link
Contributor

@nkolba nkolba commented Sep 30, 2022

  • Refactored all non-FDC3 ("runtime") handlers for greater flexibility and standardization.
  • Changed runtime window preloads to expose apis into renderer - instead of using DOM events
  • bumped Electron version
  • fixed bug introduced in previous electron upgrade that was breaking compiled builds on Mac

sebbenmbarek
sebbenmbarek approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@sebbenmbarek sebbenmbarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of code change! Handlers look good
One question:
Do we need fdc3Message.ts twice?

  • /Users/seb/Dev/norman/finos/electron-fdc3/packages/main/src/handlers/fdc3Message.ts
  • /Users/seb/Dev/norman/finos/electron-fdc3/packages/main/src/types/FDC3Message.ts

@nkolba
Copy link
Contributor Author

nkolba commented Oct 6, 2022

  • will refactor types in separate PR(s)
  • will address CVE scan in separate PR as well

@nkolba nkolba merged commit 5c6311e into finos:main Oct 6, 2022
@nkolba nkolba deleted the handlers branch October 6, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbenmbarek sebbenmbarek sebbenmbarek approved these changes

@robmoffat robmoffat Awaiting requested review from robmoffat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkolba @sebbenmbarek