Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload Refactor #66

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Preload Refactor #66

merged 1 commit into from
Oct 20, 2022

Conversation

nkolba
Copy link
Contributor

@nkolba nkolba commented Oct 16, 2022

consolidated preloads into 3 different preloads:

  • 'view' - this is for views and contains the fdc3 api only
  • 'system' - this is for system windows only - such as the window frame, resolver, search results, channel picker and only contains the sail api.
  • 'systemView' - this is for special views owned by the sail runtime - such as the home view. This contains both the fdc3 and sail apis.

Adopted the 'sail' namespace for the internal preload api.

Did a bunch of cleanup around the preloads.

Changed renderer and main to work with the new preload and api structure.

Copy link
Contributor

@sebbenmbarek sebbenmbarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot clearer.
What's sail? our new name? :D

@nkolba nkolba merged commit c96d414 into finos:main Oct 20, 2022
@nkolba nkolba deleted the preload-refactor branch October 20, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants