Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version switching based on sail manifest in appD. Some cleanup #87

Merged
merged 1 commit into from
Nov 12, 2022
Merged

version switching based on sail manifest in appD. Some cleanup #87

merged 1 commit into from
Nov 12, 2022

Conversation

nkolba
Copy link
Contributor

@nkolba nkolba commented Nov 10, 2022

No description provided.

@nkolba nkolba requested a review from robmoffat November 10, 2022 20:18
robmoffat
robmoffat approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@robmoffat robmoffat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put some comments on an old PR without realising it had been closed. This one looks a lot better.

@nkolba nkolba merged commit 45c4ae3 into finos:main Nov 12, 2022
@nkolba nkolba deleted the version-switch branch November 12, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmoffat robmoffat robmoffat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkolba @robmoffat