Typo Fixes #1012
Typo Fixes #1012
Conversation
✅ Deploy Preview for fdc3 canceled.
|
CONTRIBUTING.md
Outdated
| **4.3. Reviewing/Discussion.** | ||
| **4.3. Unit Test Policy** | ||
|
|
||
| - Any change to the FDC3 specification typescript codebase must be supoorted by accompanying unit tests. |
There was a problem hiding this comment.
Couple of types to fix:
| - Any change to the FDC3 specification typescript codebase must be supoorted by accompanying unit tests. | |
| - Any change to the FDC3 specification's typescript codebase must be supported by accompanying unit tests. |
There was a problem hiding this comment.
Removed unit test policy changes. Will keep it as a separate PR by adding some more additional details to it
CONTRIBUTING.md
Outdated
| **4.3. Reviewing/Discussion.** | ||
| **4.3. Unit Test Policy** | ||
|
|
||
| - Any change to the FDC3 specification typescript codebase must be supoorted by accompanying unit tests. |
There was a problem hiding this comment.
Some more detail would also be useful here - FDC3 is made up of 4 specifications, one of which relates to the Desktop Agent API. Most of the codebase is just typing to define that API standard. However, there is actual code in method.ts, which is currently all that we apply unit tests to. There is also code in ContextTypes.ts, which is auto-generated from context schemas. This does not currently include tests - and we might not want to be forced to add them when new Context type schemas are added and start auto-generating new functions.
There are other apps in the /toolbox directory. These don't currently have unit tests.
We might add further apps there, e.g. a basic app directory implementation - the existing out-of-date implementation was recently removed.
|
I don't have write access, requesting @greyseer256 or @kriswest to merge it |
Fixing two issues as part of my first contribution to Open Source
Please check this @robmoffat