-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order and trade experimental contexts #1021
Conversation
…ich is used to help define the other types)
✅ Deploy Preview for fdc3 canceled.
|
@nemery @hampshanubs @dominicgifford Here are those draft contexts for your review. Examples in the PR, schemas to read in the files tab. I'll add the markdown docs this week after you've had a first look (in case you see immediate changes needed). Let me know how these look ASAP please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Hugh Troeger <htroeger@factset.com>
… types and correcting schema id in message schema
You probably discussed this in one of the meetings, but what is the difference between Instrument and Product? |
@timjenkel A tradeable product might be an instrument, but it also might be a cash raise, a swap or something else. Hence, we created a product type as a place to put more detail as needed (I'm no expert but @dominicgifford, @nemery and @hampshanubs are and thought it made sense). You can see the current @experimental and extensible definition at: https://fdc3.finos.org/docs/next/context/ref/Product and how its used at https://fdc3.finos.org/docs/next/context/ref/Order and https://fdc3.finos.org/docs/next/context/ref/Trade. Feedback and further discussion are (as always) most welcome |
resolves #644
resolves #655
Experimental Order and Trade types, as discussed at Standards Working Group #1013 and Context Data & Intents #1019.
Implemented with documentation in the schema (to save adding it later when we add to all types). Markdown documentation to come. In the course of doing so, we discovered that docs should not be added for pure reference fields (it should be a description on the reference itself, and common to all usages of that reference).
These types seemed to imply a Product type, which has also been added as part of this PR.
Examples:
Order
Trade
Product
Note the nesting of the
product
inorder
under adetails
object (not itself a context). I figured that, if (as discussed) an order can have noproduct
, then it might accumulate other details fields, which it would make sense to keep together. Trade, which requires aproduct
, does not do this.