-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update position.schema.json #419
Update position.schema.json #419
Conversation
Removed the requirement to have a minimum holding of 0 as this does not support short positions
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement. Having reviewed our contributor list, we require a CLA for the following people : (@dominicgifford). If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email help@finos.org with your questions. Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. cc @finos-admin |
@dominicgifford could you take a look at https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Legal+Requirements#LegalRequirements-ContributorLicenseAgreement |
I emailed help@finos.org on 12/07 asking if my org already had a CCLA. |
@maoo @mcleo-d can you please help @dominicgifford out in terms of CLA? |
Thanks for your comment above. I am taking this forward inside FINOS and will reply to you via email with further updates. Apologies for the delay in getting back to you. James. |
Hi @dominicgifford 👋🏻 I'm pleased to confirm you have now been added to the IHS Markit CCLA and can make a minor change to this PR to see if the CLABot succeeds as done here - finos/open-developer-platform#226 (comment) @kriswest and @rikoe - This PR is ready to be reviewed and merged when ready. Let me know if more help is needed 👍🏻 Thank you and great work! James 🚀 |
added line break to trigger re-evaluation of CCLA on Pull Request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No need for a change, I was able to approve and re-run the CLA workflow on it |
👏🏻 💯 💯 💯 - Thanks all for working this through 👍🏻 |
yes, thanks to everyone :-D |
Removed the requirement to have a minimum holding of 0 as this does not support short positions.
To resolve issue #391