Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 workbench #457

Merged
merged 11 commits into from
Oct 5, 2021
Merged

FDC3 workbench #457

merged 11 commits into from
Oct 5, 2021

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Sep 17, 2021

Resolves #456

FDC3 Workbench

A developer application for FDC3 implemented via Create-React-App and Material-UI.

Please Note:

  • a separate PR will deal with the deployment of the FDC3 workbench as part of the FDC3 website. The scope of this PR includes only the initial commit of the workbench itself.
  • This initial contribution provides a base UI implementation and works with the majority of FDC3 1.2's features.
    • Implementing an additional panel for App channels is the primary TODO item listed in the Readme and will be undertaken in due course.

Screenshots

Work with System channels

image

Create, save and broadcast templated contexts

image

Listen for context broadcasts

image

Raise intents

image

Receive intents and context

image

Copy code examples

image

View logs of FDC3 API interactions

image

No desktop agent API

image

sample appD record:

(to be updated when deployed via FDC3 website)

"FDC3 workbench": {
	"appId": "FDC3 workbench",
	"name": "FDC3 workbench",
	"description": "Development and test tool for FDC3 desktop agents and apps",
	"manifest": "<vendor specific manifest goes here>",
	"version": "1.0.0",
	"tooltip": "FDC3 Workbench",
	"images": [
		{
			"url": "https://assets.finsemble.com/components/fdc3-workbench/fdc3-icon-256.png",
			"tooltip": "FDC3 logo"
		}
	],
	"tags": ["fdc3", "interop", "interoperabilty", "developer tool"],
	"contactEmail": "info@cosaic.io",
	"supportEmail": "support@finsemble.com",
	"publisher": "Cosaic",
	"icons": [
		{
			"url": "https://assets.finsemble.com/components/fdc3-workbench/fdc3-icon-256.png"
		}
	]
}

@kriswest kriswest added the toolbox Apps or code that isn't part of the standard but supports it use label Sep 17, 2021
@kriswest kriswest mentioned this pull request Sep 21, 2021
14 tasks
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

…n't think its using the deprecated function signature
…website to github pages.

To test run the following in the website/ directory: yarn; yarn copy-workbench; yarn start you should then be able to test the workbench at http://localhost:3000/toolbox/fdc3-workbench/
package.json scripts to build and deploy the fdc3-workbench with the website to gh-pages
Copy link
Contributor

@rikoe rikoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the binary files under website/static/toolbox all be checked in, or can they be generated at build time, and pushed to the GitHub pages branch, and then ignore? Adds quite a lot to the code base...

Otherwise looks good to me (apart from the extremely wide whitespace 😉 )

@kriswest
Copy link
Contributor Author

kriswest commented Oct 5, 2021

@rikoe removed the built files. I haven't set up a .gitignore entry for them as I'm not sure if that will affect the publish to github pages... do you know how to set that up?

Re: whitespace, it's all indented with tabs, which is whats set in it's .prettierrc file...

@kriswest kriswest requested a review from rikoe October 5, 2021 13:09
Copy link
Contributor

@rikoe rikoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kriswest kriswest merged commit 5eb5383 into finos:master Oct 5, 2021
@kriswest kriswest deleted the FDC3-workbench branch October 8, 2021 11:34
@kriswest kriswest mentioned this pull request Oct 22, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present toolbox Apps or code that isn't part of the standard but supports it use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FDC3 Workbench - developer example application
3 participants