Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify broadcast of complex context types #464

Merged

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Sep 28, 2021

Resolves #434
Adds advice to the spec and documentation about how to broadcast complex context types, where other apps on the channel may wish to/are set up to process simpler types that are the fields of your context type. The consensus from #452 was to broadcast each type you want others to respond to separately.
E.g. when broadcasting an fdc3.position, which has an fdc3.instrument field, broadcast instrument and then position.

@kriswest kriswest added this to the 2.0 milestone Sep 28, 2021
@kriswest kriswest requested a review from a team September 28, 2021 16:47
@kriswest kriswest changed the title Resolves #434 Clarify broadcast of complex context types Clarify broadcast of complex context types Sep 28, 2021
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we can do better on this, perhaps by providing a mechanism for developers to register context adapters to extract the simple types from the composite type. Though maybe that's an opportunity for vendor platform differentiation. 😁

@kriswest
Copy link
Contributor Author

kriswest commented Oct 7, 2021

@mattjamieson I added some example code for that to the issue (#434), which could go into methods.ts. However, if we're recommending/specifying that each type should be broadcast (rapid-fire) then I think it difficult to mix that with a feature to auto-extract types, as combining the two will lead to the same context being received multiple times in rapid succession (and perhaps some flickering?). That could also be dealt with in the implementation (don't redeliver an identical context in a short timespan), but that puts doing so firmly into a specific implementation, rather than the spec

@kriswest kriswest requested a review from a team October 7, 2021 09:03
@mattjamieson
Copy link
Contributor

[...] but that puts doing so firmly into a specific implementation, rather than the spec

Yes, I agree, I think decisions on this stay in implementation-land for now while we see how usage develops.

@rikoe rikoe merged commit 16aa9f5 into finos:master Oct 7, 2021
@kriswest kriswest deleted the 434-clarify-broadcast-of-multiple-types branch October 8, 2021 11:31
@kriswest kriswest mentioned this pull request Oct 22, 2021
11 tasks
@kriswest kriswest added api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group context-data FDC3 Context Data Working Group labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group cla-present context-data FDC3 Context Data Working Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how apps should handle broadcast and receipt of multiple context types
3 participants